Skip to content

[WIP] Add facility to read samples from byte arrays #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Copilot wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add facility to read samples from byte arrays #70

Copilot wants to merge 3 commits into from

Conversation

Copy link
Contributor

Copilot AI commented Jan 6, 2026 •
edited
Loading

Plan: Add support for reading samples from byte arrays

  • Understand current code structure and how sources are created
  • Add NewFromSamples() constructor to source package
  • Add NewFromReader() constructor to source package that accepts io.Reader
  • Update bind/api.go to add LoadWAVFromReader() function
  • Add comprehensive tests for new functionality
  • Run tests to validate changes
  • Update documentation if needed
Original prompt

This section details on the original issue you should resolve

<issue_title>Reading samples from byte arrays</issue_title>
<issue_description>Is there a facility in place to read samples from byte arrays instead of from files? And if not, how would one go about doing that in the most elegant manner in order to bypass the file reading and read from byte arrays instead?</issue_description>

Comments on the Issue (you are @copilot in this section)

@charneykaye Almost, but it seems we would need to create an alternate way of constructing a **Source**

https://github.com/go-mix/mix/blob/master/lib/source/source.go#L19-L27</comment_new>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits January 6, 2026 09:47
@charneykaye
Initial plan for reading samples from byte arrays
e07a869 
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
@charneykaye
Changes before error encountered
a3e55f0 
Co-authored-by: charneykaye <8584836+charneykaye@users.noreply.github.com>
Copilot AI requested a review from charneykaye January 6, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@charneykaye charneykaye Awaiting requested review from charneykaye

Assignees

@charneykaye charneykaye

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reading samples from byte arrays

2 participants

@charneykaye